RESOLVED FIXED180725
We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize
https://bugs.webkit.org/show_bug.cgi?id=180725
Summary We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseL...
Saam Barati
Reported 2017-12-12 16:27:43 PST
...
Attachments
patch (5.15 KB, patch)
2017-12-12 16:30 PST, Saam Barati
msaboff: review+
patch for landing (5.16 KB, patch)
2017-12-12 16:37 PST, Saam Barati
no flags
Saam Barati
Comment 1 2017-12-12 16:28:12 PST
Saam Barati
Comment 2 2017-12-12 16:30:58 PST
Michael Saboff
Comment 3 2017-12-12 16:33:35 PST
Comment on attachment 329176 [details] patch r=me
Mark Lam
Comment 4 2017-12-12 16:34:52 PST
Comment on attachment 329176 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=329176&action=review > JSTests/ChangeLog:3 > + We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize /need model/need to model/ > Source/JavaScriptCore/ChangeLog:3 > + We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize /need model/need to model/ > Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:123 > + auto readSpreadOfPhanomCreateRest = [&] (Node* spread) { typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/ > Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:138 > + readSpreadOfPhanomCreateRest(child); typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/ > Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:184 > + readSpreadOfPhanomCreateRest(m_node->argumentsChild().node()); typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/ > Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:208 > + readSpreadOfPhanomCreateRest(m_node); /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/
Saam Barati
Comment 5 2017-12-12 16:37:35 PST
Created attachment 329178 [details] patch for landing
WebKit Commit Bot
Comment 6 2017-12-12 19:04:26 PST
Comment on attachment 329178 [details] patch for landing Clearing flags on attachment: 329178 Committed r225834: <https://trac.webkit.org/changeset/225834>
WebKit Commit Bot
Comment 7 2017-12-12 19:04:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.