Bug 180725 - We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize
Summary: We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-12 16:27 PST by Saam Barati
Modified: 2017-12-12 19:04 PST (History)
13 users (show)

See Also:

Attachments
patch (5.15 KB, patch)
2017-12-12 16:30 PST, Saam Barati 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (5.16 KB, patch)
2017-12-12 16:37 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-12 16:27:43 PST 
...
Comment 1 Saam Barati 2017-12-12 16:28:12 PST 
<rdar://problem/35970511>
Comment 2 Saam Barati 2017-12-12 16:30:58 PST 
Created attachment 329176 [details]
patch
Comment 3 Michael Saboff 2017-12-12 16:33:35 PST 
Comment on attachment 329176 [details]
patch

r=me
Comment 4 Mark Lam 2017-12-12 16:34:52 PST 
Comment on attachment 329176 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329176&action=review

> JSTests/ChangeLog:3
> +        We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize

/need model/need to model/

> Source/JavaScriptCore/ChangeLog:3
> +        We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize

/need model/need to model/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:123
> +        auto readSpreadOfPhanomCreateRest = [&] (Node* spread) {

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:138
> +                        readSpreadOfPhanomCreateRest(child);

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:184
> +                    readSpreadOfPhanomCreateRest(m_node->argumentsChild().node());

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:208
> +                readSpreadOfPhanomCreateRest(m_node);

/readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/
Comment 5 Saam Barati 2017-12-12 16:37:35 PST 
Created attachment 329178 [details]
patch for landing
Comment 6 WebKit Commit Bot 2017-12-12 19:04:26 PST 
Comment on attachment 329178 [details]
patch for landing

Clearing flags on attachment: 329178

Committed r225834: <https://trac.webkit.org/changeset/225834>
Comment 7 WebKit Commit Bot 2017-12-12 19:04:28 PST 
All reviewed patches have been landed.  Closing bug.