Bug 180709 – WebGL TextureMapperShaderProgram shaders don't compile in MSVC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Christopher Reid]

MSVC likes to expand __VA_ARGS__ differently than clang and gcc which is causing shader programs to not compile in TextureMapperShaderProgram.cpp due to "#if USE(OPENGL_ES_2)" being added to the shader programs.

[Christopher Reid]

Here's a simple program compiled in MSVC to show what is happening and the difference in expansion:
MSVC: http://rextester.com/PXT40494
CLANG: http://rextester.com/SZXMYM65465 (GCC acts the same as CLANG)

[Christopher Reid]

Created attachment 329138 [details]
patch

[EWS Watchlist]

Attachment 329138 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:66:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:187:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 329138 [details]
patch

Clearing flags on attachment: 329138

Committed r225800: <https://trac.webkit.org/changeset/225800>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36002359>