Bug 180699 - getUserMedia is resolving before the document knows it is capturing
Summary: getUserMedia is resolving before the document knows it is capturing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-12 09:13 PST by youenn fablet
Modified: 2017-12-12 17:40 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.73 KB, patch)
2017-12-12 10:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (21.88 KB, patch)
2017-12-12 11:19 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (16.16 KB, patch)
2017-12-12 13:38 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (16.16 KB, patch)
2017-12-12 15:17 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-12 09:13:27 PST 
Sometimes getUserMedia promise will be resolved and autoplay will not be disabled as the promise resolves before the stream is producing data and the document knows it is capturing.
We may want to delay promise resolution until the stream is ready to produce data.
Comment 1 youenn fablet 2017-12-12 10:09:51 PST 
Created attachment 329119 [details]
Patch
Comment 2 youenn fablet 2017-12-12 11:19:12 PST 
Created attachment 329130 [details]
Patch
Comment 3 youenn fablet 2017-12-12 13:38:35 PST 
Created attachment 329148 [details]
Rebasing
Comment 4 Eric Carlson 2017-12-12 15:12:46 PST 
Comment on attachment 329148 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=329148&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> +    {

Nit: indentation.
Comment 5 youenn fablet 2017-12-12 15:17:33 PST 
Created attachment 329166 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-12-12 17:39:39 PST 
Comment on attachment 329166 [details]
Patch for landing

Clearing flags on attachment: 329166

Committed r225828: <https://trac.webkit.org/changeset/225828>
Comment 7 WebKit Commit Bot 2017-12-12 17:39:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-12 17:40:32 PST 
<rdar://problem/36010366>