Bug 180697 – Make ServiceWorkers follow the DEFAULT_EXPERIMENTAL_FEATURES_ENABLED flag on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

As a first step towards activating service worker everywhere, make Service Worker experimental flag on by default.

[youenn fablet]

Created attachment 329115 [details]
Patch

[Chris Dumez]

Comment on attachment 329115 [details]
Patch

I am unclear if this enables the feature on iOS or not. I think we'd want to hold off on iOS a bit until we do some basic testing.

[Brady Eidson]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 329115 [details]
> Patch
> 
> I am unclear if this enables the feature on iOS or not. I think we'd want to
> hold off on iOS a bit until we do some basic testing.

Right. That's the reason why I hadn't done this yet (e.g resolve the radar) because I'm waiting on input on how to use the yaml to be Mac only.

[Brady Eidson]

Comment on attachment 329115 [details]
Patch

Gotta do this differently

[Brady Eidson]

*** Bug 180700 has been marked as a duplicate of this bug. ***

[Brady Eidson]

Created attachment 329118 [details]
Patch

[Chris Dumez]

Comment on attachment 329118 [details]
Patch

r=me assuming iOS EWS is happy.

[Brady Eidson]

It's no good, but I have a good fix.

[Brady Eidson]

Created attachment 329123 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 329123 [details]
Patch

Clearing flags on attachment: 329123

Committed r225789: <https://trac.webkit.org/changeset/225789>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brady Eidson]

<rdar://problem/35978311>

[Matt Lewis]

This caused multiple API failures on all macOS platforms:



https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio
Build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio

The failing tests:

WKProcessPool.InitialWarmedProcessUsed

Failure:
FAIL WKProcessPool.InitialWarmedProcessUsed

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:51
Value of: static_cast<size_t>(1)
  Actual: 1
Expected: [pool _webProcessCount]
Which is: 2


WebKit.WebsiteDataStoreCustomPaths

FAIL WebKit.WebsiteDataStoreCustomPaths

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:219
Value of: [WKWebsiteDataStore _defaultDataStoreExists]
  Actual: true
Expected: false


The test passed before this patch and now fail consistently

[Matt Lewis]

New bug for the failures and the fix:
https://bugs.webkit.org/show_bug.cgi?id=180722