Bug 180690 - ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in Web Inspector console
Summary: ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-11 22:02 PST by zalan
Modified: 2017-12-13 10:43 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.79 KB, patch)
2017-12-11 22:06 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2017-12-13 08:36 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2017-12-13 10:09 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-12-11 22:02:35 PST
rdar://problem/35345162
Comment 1 zalan 2017-12-11 22:06:13 PST
Created attachment 329089 [details]
Patch
Comment 2 zalan 2017-12-13 08:36:25 PST
Created attachment 329220 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-12-13 09:58:58 PST
Comment on attachment 329220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329220&action=review

> Source/WebCore/ChangeLog:8
> +        Defer text replacement notification until after layout is done to avoid unexpected force layouts.

forced
Comment 4 zalan 2017-12-13 10:09:40 PST
Created attachment 329228 [details]
Patch
Comment 5 WebKit Commit Bot 2017-12-13 10:43:09 PST
Comment on attachment 329228 [details]
Patch

Clearing flags on attachment: 329228

Committed r225855: <https://trac.webkit.org/changeset/225855>
Comment 6 WebKit Commit Bot 2017-12-13 10:43:11 PST
All reviewed patches have been landed.  Closing bug.