Bug 180685 – REGRESSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/671
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/671/steps/webkit-32bit-jsc-test/logs/stdio

failure:
ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default

ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default: Detected failures:
ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default: *** Running test #4 (3): A character set containing a range spanning multiple planes should match characters from all those planes
ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default: Test threw exception: assert.isTrue failed: expected: true actual: false: First character in plane #1
ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default: FAILED
ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default: Summary of tests: total executed: 7; passed: 6; failed: 1
FAIL: ChakraCore.yaml/ChakraCore/test/es6/regex-unicode.js.default

[Radar WebKit Bug Importer]

<rdar://problem/35982788>

[Michael Saboff]

Created attachment 329060 [details]
Patch

[Alex Christensen]

Comment on attachment 329060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329060&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        REGREASSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds

I don't understand why this would be specific to 32-bit builds.

[Michael Saboff]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 329060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329060&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        REGREASSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds
> 
> I don't understand why this would be specific to 32-bit builds.

Because Unicode regular expressions are handled by JIT'ed code on 64 bit platforms.  The failure was in the interpreter.

[Michael Saboff]

Committed r225771: <https://trac.webkit.org/changeset/225771>