Bug 180679 – Storage Access API: Implement frame-specific access in the network storage session layer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[John Wilander]

This is part 1 of making Storage Access API frame-specific.

[Radar WebKit Bug Importer]

<rdar://problem/35982116>

[John Wilander]

Created attachment 329076 [details]
Patch

[John Wilander]

Style errors are of the "Extra space before ( in function call" variety.

[EWS Watchlist]

Attachment 329076 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1414:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:271:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:353:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ChromeClient.h:471:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:5824:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1028:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:1264:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 329076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329076&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:288
> +    WTFLogAlways("ResourceLoadLog | NetworkStorageSession::isStorageAccessGranted(), resourceDomain: %s, firstPartyDomain: %s, frameID: %llu, pageID: %llu.", resourceDomain.utf8().data(), firstPartyDomain.utf8().data(), frameID, pageID);

Let's not add a WTFLogAlways here.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:302
> +    WTFLogAlways("ResourceLoadLog | NetworkStorageSession::setStorageAccessGranted(), resourceDomain: %s, firstPartyDomain: %s, frameID: %llu, pageID: %llu.", resourceDomain.utf8().data(), firstPartyDomain.utf8().data(), frameID, pageID);

Also remove this log.

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:413
> +    // Dummy

Remove.

> LayoutTests/http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame-expected.txt:19
> +Client-side document.cookie: partitionedCookie=value

Once CookieJarMac is updated, this result will change.

[John Wilander]

Created attachment 329179 [details]
Patch for landing

[John Wilander]

Fixed the stray log calls and the dummy comment. Thanks, Alex!

[WebKit Commit Bot]

Comment on attachment 329179 [details]
Patch for landing

Clearing flags on attachment: 329179

Committed r225827: <https://trac.webkit.org/changeset/225827>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Konstantin Tokarev]

Could you consider renaming test files to make their names more concise? Linux users with eCryptfs cannot work with file names longer than 143 characters. Also, such long names may create troubles on Windows, where total path length is limited by 260 characters or so