WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180659
Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=180659
Summary
Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.htt...
Ryan Haddad
Reported
2017-12-11 10:12:14 PST
The following layout test is flaky on macOS and iOS WK2: http/tests/workers/service/postmessage-after-sw-process-crash.https.html Probable cause: Test was added with
https://trac.webkit.org/changeset/225622/webkit
Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fpostmessage-after-sw-process-crash.https.html
--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/postmessage-after-sw-process-crash.https-actual.txt @@ -3,6 +3,5 @@ PASS: Service worker received message 'Message 1' from origin '
https://127.0.0.1:8443
' * Simulating Service Worker process crash * Sending 'Message 2' to Service Worker -PASS: Client received message from service worker, origin:
https://127.0.0.1:8443
-PASS: Service worker received message 'Message 2' from origin '
https://127.0.0.1:8443
' +FAIL: Did not receive message from service worker process after the crash
Attachments
Patch
(8.46 KB, patch)
2017-12-11 13:43 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(8.76 KB, patch)
2017-12-11 14:16 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2017-12-11 10:32:16 PST
Will take a look.
Chris Dumez
Comment 2
2017-12-11 13:43:36 PST
Created
attachment 329027
[details]
Patch
youenn fablet
Comment 3
2017-12-11 14:03:40 PST
Comment on
attachment 329027
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=329027&action=review
> Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp:133 > + server().runServiceWorkerIfNecessary(destinationIdentifier, [destinationIdentifier, message = message.vector(), sourceIdentifier, sourceData = WTFMove(sourceData)](bool success, auto& contextConnection) mutable {
No need for message to be passed as an r value. This is so easy to fall into the trap of copying a DataReference and thinking that it will copy the data it refers to. Maybe DataReference should not be copy constructible, one can still explicitly create a DataReference with one of its other constructor.
> LayoutTests/http/tests/workers/service/resources/postmessage-after-sw-process-crash.js:18 > + }, 10);
For that kind of pattern, I usually like to do this ping for a number of time and fail afterwards with an explicit message. This allows making test messages in case of timeouts more precise.
Chris Dumez
Comment 4
2017-12-11 14:16:06 PST
Created
attachment 329034
[details]
Patch
WebKit Commit Bot
Comment 5
2017-12-11 14:49:13 PST
Comment on
attachment 329034
[details]
Patch Clearing flags on attachment: 329034 Committed
r225758
: <
https://trac.webkit.org/changeset/225758
>
WebKit Commit Bot
Comment 6
2017-12-11 14:49:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2017-12-11 14:50:49 PST
<
rdar://problem/35979040
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug