Bug 180656 - [WTF] Add Converter traits to StringHasher instead of function pointer
Summary: [WTF] Add Converter traits to StringHasher instead of function pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-11 10:04 PST by Yusuke Suzuki
Modified: 2017-12-17 05:57 PST (History)
9 users (show)

See Also:

Attachments
Patch (12.68 KB, patch)
2017-12-11 10:07 PST, Yusuke Suzuki 		jfbastien: review+
Details | Formatted Diff | Diff
Patch for landing (14.39 KB, patch)
2017-12-11 10:31 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-11 10:04:24 PST 
[WTF] Add Converter traits to StringHasher instead of function pointer
Comment 1 Yusuke Suzuki 2017-12-11 10:07:19 PST 
Created attachment 328995 [details]
Patch
Comment 2 JF Bastien 2017-12-11 10:19:08 PST 
Comment on attachment 328995 [details]
Patch

Thanks for the quick fix! r=me
Comment 3 Yusuke Suzuki 2017-12-11 10:20:51 PST 
Comment on attachment 328995 [details]
Patch

Thank you!
Comment 4 Yusuke Suzuki 2017-12-11 10:25:09 PST 
Comment on attachment 328995 [details]
Patch

Oops, ios-sim has another converter code. I'll fix it before landing.
Comment 5 Yusuke Suzuki 2017-12-11 10:31:27 PST 
Created attachment 328999 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-12-11 11:22:04 PST 
Comment on attachment 328999 [details]
Patch for landing

Clearing flags on attachment: 328999

Committed r225751: <https://trac.webkit.org/changeset/225751>
Comment 7 Radar WebKit Bug Importer 2017-12-17 05:57:39 PST 
<rdar://problem/36095077>