Web Inspector: support async setup() and async teardown() in AsyncTestSuite

[BJ Burg]

I found a use for this.

[BJ Burg]

Created attachment 328916 [details]
Proposed Fix

[Timothy Hatcher]

Comment on attachment 328916 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=328916&action=review

> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:142
> +                    if (testcase.test[Symbol.toStringTag] === "AsyncFunction")

So if test case.test() is async, then we assume testcase.setup() is too? Or should this test testcase.setup[Symbol.toStringTag]? Assert here one way or another?

> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:163
> +                    if (testcase.test[Symbol.toStringTag] === "AsyncFunction")

Ditto for testcase.teardown().

[BJ Burg]

(In reply to Timothy Hatcher from comment #2)
> Comment on attachment 328916 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328916&action=review
> 
> > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:142
> > +                    if (testcase.test[Symbol.toStringTag] === "AsyncFunction")
> 
> So if test case.test() is async, then we assume testcase.setup() is too? Or
> should this test testcase.setup[Symbol.toStringTag]? Assert here one way or
> another?
> 
> > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:163
> > +                    if (testcase.test[Symbol.toStringTag] === "AsyncFunction")
> 
> Ditto for testcase.teardown().

Ooh, copypasta. It's supposed to be .setup and .teardown.

[BJ Burg]

Created attachment 329152 [details]
Proposed Fix

[WebKit Commit Bot]

Comment on attachment 329152 [details]
Proposed Fix

Clearing flags on attachment: 329152

Committed r225820: <https://trac.webkit.org/changeset/225820>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36008686>