Bug 180624 - [WTF] Remove RELAXED_CONSTEXPR
Summary: [WTF] Remove RELAXED_CONSTEXPR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-09 12:26 PST by Yusuke Suzuki
Modified: 2017-12-09 13:43 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2017-12-09 12:27 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-09 12:26:13 PST 
[WTF] Remove RELAXED_CONSTEXPR
Comment 1 Yusuke Suzuki 2017-12-09 12:27:42 PST 
Created attachment 328913 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-09 12:28:28 PST 
I believe it works in VC++ 2017. Watching on EWS.
Comment 3 EWS Watchlist 2017-12-09 12:29:34 PST 
Attachment 328913 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Expected.h:485:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WTF/wtf/Expected.h:491:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WTF/wtf/Expected.h:494:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WTF/wtf/Expected.h:554:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 JF Bastien 2017-12-09 13:00:23 PST 
Comment on attachment 328913 [details]
Patch

🎉 =me r=me
Comment 5 Yusuke Suzuki 2017-12-09 13:21:53 PST 
Comment on attachment 328913 [details]
Patch

Yay, EWS becomes green. I'll land this :)
Comment 6 WebKit Commit Bot 2017-12-09 13:42:06 PST 
Comment on attachment 328913 [details]
Patch

Clearing flags on attachment: 328913

Committed r225728: <https://trac.webkit.org/changeset/225728>
Comment 7 WebKit Commit Bot 2017-12-09 13:42:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-09 13:43:36 PST 
<rdar://problem/35953465>