Bug 180615 - ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL
Summary: ServiceWorkerGlobalScope is a global object and should be marked as [Implicit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-08 16:23 PST by Chris Dumez
Modified: 2017-12-08 19:45 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.96 KB, patch)
2017-12-08 16:24 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2017-12-08 16:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-08 16:23:21 PST 
ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL, similarly to what we do for Window.
This allows a getter to be fallback to the global object as ThisValue when the cast of the ThisValue to the expected type fails.
Comment 1 Chris Dumez 2017-12-08 16:24:21 PST 
Created attachment 328883 [details]
Patch
Comment 2 Chris Dumez 2017-12-08 16:26:34 PST 
Created attachment 328884 [details]
Patch
Comment 3 WebKit Commit Bot 2017-12-08 19:44:36 PST 
Comment on attachment 328884 [details]
Patch

Clearing flags on attachment: 328884

Committed r225718: <https://trac.webkit.org/changeset/225718>
Comment 4 WebKit Commit Bot 2017-12-08 19:44:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-08 19:45:24 PST 
<rdar://problem/35949192>