Bug 180613 - WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Summary: WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-08 15:56 PST by mitz
Modified: 2017-12-16 12:57 PST (History)
4 users (show)

See Also:

Attachments
WIP (20.61 KB, patch)
2017-12-16 00:29 PST, mitz 		no flags Details | Formatted Diff | Diff
WIP (20.59 KB, patch)
2017-12-16 00:35 PST, mitz 		no flags Details | Formatted Diff | Diff
Add _alwaysShows{Horizontal,Vertical}Scroller properties (35.85 KB, patch)
2017-12-16 09:13 PST, mitz 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-12-08 15:56:39 PST 
WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Comment 1 mitz 2017-12-08 15:58:40 PST 
<rdar://problem/35946124>
Comment 2 mitz 2017-12-16 00:29:15 PST 
Created attachment 329566 [details]
WIP
Comment 3 EWS Watchlist 2017-12-16 00:31:21 PST 
Attachment 329566 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4928:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4941:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2017-12-16 00:35:23 PST 
Created attachment 329568 [details]
WIP
Comment 5 EWS Watchlist 2017-12-16 00:38:42 PST 
Attachment 329568 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 mitz 2017-12-16 09:13:45 PST 
Created attachment 329578 [details]
Add _alwaysShows{Horizontal,Vertical}Scroller properties
Comment 7 EWS Watchlist 2017-12-16 09:16:16 PST 
Attachment 329578 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2017-12-16 12:51:20 PST 
Comment on attachment 329578 [details]
Add _alwaysShows{Horizontal,Vertical}Scroller properties

r=me
Comment 9 mitz 2017-12-16 12:57:24 PST 
Fixed in <https://trac.webkit.org/r226008>.