Bug 18061 - PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
Summary: PlatformScrollBarGtk attempts to allocate negative width and/or height for wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL: http://acid3.acidtests.org/
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-03-25 02:04 PDT by Jasper Bryant-Greene
Modified: 2008-03-28 11:27 PDT (History)
1 user (show)

See Also:

Attachments
prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets (1.52 KB, patch)
2008-03-25 02:05 PDT, Jasper Bryant-Greene 		alp: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jasper Bryant-Greene 2008-03-25 02:04:46 PDT 
The attached patch adds a missing clampNegativeToZero() call to stop PlatformScrollBarGtk from allocating negative width and/or height for widgets.

This stops massive barfage of warnings like this on, for example, the Acid3 test:

(juniper:12951): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -15 and height 15
Comment 1 Jasper Bryant-Greene 2008-03-25 02:05:32 PDT 
Created attachment 20024 [details]
prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets
Comment 2 Alp Toker 2008-03-28 11:27:10 PDT 
Landed in r31399.

Including the bug URL/subject in the ChangeLog entry is a good idea for future patches. I also removed the comment since it's self-explanatory.

Thanks!