Bug 180585 - Service Worker should use a correct SessionID
Summary: Service Worker should use a correct SessionID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-08 08:35 PST by youenn fablet
Modified: 2017-12-08 14:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.70 KB, patch)
2017-12-08 10:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.39 KB, patch)
2017-12-08 10:34 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.20 KB, patch)
2017-12-08 12:29 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.21 KB, patch)
2017-12-08 13:07 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-08 08:35:32 PST 
Currently it is using a default one.
Comment 1 youenn fablet 2017-12-08 10:24:43 PST 
Created attachment 328829 [details]
Patch
Comment 2 youenn fablet 2017-12-08 10:34:32 PST 
Created attachment 328831 [details]
Patch
Comment 3 youenn fablet 2017-12-08 12:29:54 PST 
Created attachment 328853 [details]
Patch
Comment 4 youenn fablet 2017-12-08 13:07:09 PST 
Created attachment 328858 [details]
Patch
Comment 5 EWS Watchlist 2017-12-08 13:09:13 PST 
Attachment 328858 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/server/SWServer.cpp:200:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/workers/service/server/SWServer.cpp:202:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/workers/service/server/SWServer.cpp:203:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2017-12-08 14:44:30 PST 
Comment on attachment 328858 [details]
Patch

Clearing flags on attachment: 328858

Committed r225703: <https://trac.webkit.org/changeset/225703>
Comment 7 WebKit Commit Bot 2017-12-08 14:44:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-08 14:45:36 PST 
<rdar://problem/35944220>