RESOLVED FIXED 180581
[GTK] Issues with Ahem's ex / x-height 
https://bugs.webkit.org/show_bug.cgi?id=180581
Summary [GTK] Issues with Ahem's ex / x-height
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-12-08 07:24:28 PST
Cairo does not allow us to extract the defined x-height from a font, and we instead need to draw an "x" and measure it with cairo_scaled_font_text_extents. The Ahem font has a defined x-height of 0.8em, which does not seem to match the result of cairo_scaled_font_text_extents. This causes a number of our tests that use the font to fail on GTK.
Attachments
Patch (6.19 KB, patch)
2018-01-03 03:29 PST, Carlos Garcia Campos 		mcatanzaro: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.60 MB, application/zip)
2018-01-03 10:23 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-01-03 03:29:28 PST
Created attachment 330372 [details] Patch With this patch we get different (and better?) results for those tests, but most of them still fail. I'm getting the same results with chromium though, so maybe we can consider them good enough and simply rebaseline.
EWS Watchlist
Comment 2 2018-01-03 10:23:44 PST
Comment on attachment 330372 [details] Patch Attachment 330372 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5915758 New failing tests: fast/mediastream/MediaStream-MediaElement-setObject-null.html
EWS Watchlist
Comment 3 2018-01-03 10:23:45 PST
Created attachment 330400 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Carlos Garcia Campos
Comment 4 2018-01-04 02:04:42 PST
Committed r226404: <https://trac.webkit.org/changeset/226404>
Carlos Garcia Campos
Comment 5 2018-01-04 02:05:59 PST
Landed patch includes a rebaseline. What do we do with the other tests still pointing to this bug in expectations? Do we reopen the bug or rebaseline the tests?
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 6 2018-01-04 03:54:19 PST
The other tests are based on testharness.js. As long as there's FAILs in the output, I think we need a bug for them.
Note You need to log in before you can comment on or make changes to this bug.