WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180579
[WTF] Remove remaining use of Mutex
https://bugs.webkit.org/show_bug.cgi?id=180579
Summary
[WTF] Remove remaining use of Mutex
Yusuke Suzuki
Reported
2017-12-08 05:02:24 PST
[WTF] Remove remaining use of Mutex
Attachments
Patch
(10.56 KB, patch)
2017-12-08 05:04 PST
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(10.90 KB, patch)
2017-12-08 05:14 PST
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(10.89 KB, patch)
2017-12-08 06:07 PST
,
Yusuke Suzuki
achristensen
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2017-12-08 05:04:14 PST
Created
attachment 328803
[details]
Patch
Yusuke Suzuki
Comment 2
2017-12-08 05:14:54 PST
Created
attachment 328804
[details]
Patch
EWS Watchlist
Comment 3
2017-12-08 05:17:49 PST
Attachment 328804
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 4
2017-12-08 06:07:17 PST
Created
attachment 328809
[details]
Patch
EWS Watchlist
Comment 5
2017-12-08 06:09:34 PST
Attachment 328809
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 6
2017-12-08 07:30:02 PST
WinCairo failure seems related to incremental build issue.
Alex Christensen
Comment 7
2017-12-08 09:01:24 PST
Comment on
attachment 328809
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=328809&action=review
> Source/WTF/wtf/win/WorkQueueWin.cpp:159 > + HANDLE timer { 0 };
I think this could be nullptr.
Yusuke Suzuki
Comment 8
2017-12-08 09:42:33 PST
Comment on
attachment 328809
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=328809&action=review
Thanks!
>> Source/WTF/wtf/win/WorkQueueWin.cpp:159 >> + HANDLE timer { 0 }; > > I think this could be nullptr.
Nice, fixed.
Yusuke Suzuki
Comment 9
2017-12-08 09:48:43 PST
Committed
r225681
: <
https://trac.webkit.org/changeset/225681
>
Radar WebKit Bug Importer
Comment 10
2017-12-08 09:49:33 PST
<
rdar://problem/35936516
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug