Bug 180579 - [WTF] Remove remaining use of Mutex
Summary: [WTF] Remove remaining use of Mutex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-08 05:02 PST by Yusuke Suzuki
Modified: 2017-12-08 09:49 PST (History)
11 users (show)

See Also:

Attachments
Patch (10.56 KB, patch)
2017-12-08 05:04 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (10.90 KB, patch)
2017-12-08 05:14 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2017-12-08 06:07 PST, Yusuke Suzuki 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-08 05:02:24 PST 
[WTF] Remove remaining use of Mutex
Comment 1 Yusuke Suzuki 2017-12-08 05:04:14 PST 
Created attachment 328803 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-08 05:14:54 PST 
Created attachment 328804 [details]
Patch
Comment 3 EWS Watchlist 2017-12-08 05:17:49 PST 
Attachment 328804 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2017-12-08 06:07:17 PST 
Created attachment 328809 [details]
Patch
Comment 5 EWS Watchlist 2017-12-08 06:09:34 PST 
Attachment 328809 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Yusuke Suzuki 2017-12-08 07:30:02 PST 
WinCairo failure seems related to incremental build issue.
Comment 7 Alex Christensen 2017-12-08 09:01:24 PST 
Comment on attachment 328809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328809&action=review

> Source/WTF/wtf/win/WorkQueueWin.cpp:159
> +    HANDLE timer { 0 };

I think this could be nullptr.
Comment 8 Yusuke Suzuki 2017-12-08 09:42:33 PST 
Comment on attachment 328809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328809&action=review

Thanks!

>> Source/WTF/wtf/win/WorkQueueWin.cpp:159
>> +    HANDLE timer { 0 };
> 
> I think this could be nullptr.

Nice, fixed.
Comment 9 Yusuke Suzuki 2017-12-08 09:48:43 PST 
Committed r225681: <https://trac.webkit.org/changeset/225681>
Comment 10 Radar WebKit Bug Importer 2017-12-08 09:49:33 PST 
<rdar://problem/35936516>