Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
Created attachment 328790 [details] Patch
Comment on attachment 328790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328790&action=review r=me > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:52 > + ASSERT_WITH_MESSAGE(!const_cast<Lock&>(m_lock).tryLock(), "CAView::Handle's mutex must be held when calling this function"); Consider changing "mutex" to "lock". > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:58 > + ASSERT_WITH_MESSAGE(!m_lock.tryLock(), "CAView::Handle's mutex must be held when calling this function"); Consider changing "mutex" to "lock".
Created attachment 328795 [details] Patch Fix build failure
Comment on attachment 328790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328790&action=review Thanks! >> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:52 >> + ASSERT_WITH_MESSAGE(!const_cast<Lock&>(m_lock).tryLock(), "CAView::Handle's mutex must be held when calling this function"); > > Consider changing "mutex" to "lock". Fixed. >> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:58 >> + ASSERT_WITH_MESSAGE(!m_lock.tryLock(), "CAView::Handle's mutex must be held when calling this function"); > > Consider changing "mutex" to "lock". Fixed.
Created attachment 328797 [details] Patch Fix build failure
Attachment 328797 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:120: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328799 [details] Patch Fix build failure
Attachment 328799 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:120: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328802 [details] Patch for landing Patch for landing
Attachment 328802 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:120: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 328802 [details] Patch for landing Clearing flags on attachment: 328802 Committed r225672: <https://trac.webkit.org/changeset/225672>
<rdar://problem/35932629>