Bug 180561 – Move Logger from PAL to WTF so it can be used outside of WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric Carlson]

Move Logger from PAL to WTF so it can be used outside of WebCore

[Radar WebKit Bug Importer]

<rdar://problem/35924554>

[Eric Carlson]

Created attachment 328763 [details]
Proposed patch.

[EWS Watchlist]

Attachment 328763 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 328768 [details]
Updated patch.

[Alex Christensen]

Comment on attachment 328768 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=328768&action=review

r=me with comments

> Source/WTF/wtf/Logger.h:224
> +} // namespace PAL

This should be namespace WTF

> Source/WebCore/html/track/TrackBase.cpp:38
> +using namespace WTF;

Many WTF header files end with using WTF::Something;
Let's do that instead of this.
Then we can also replace the WTF::Logger with Logger

[Eric Carlson]

Comment on attachment 328768 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=328768&action=review

>> Source/WTF/wtf/Logger.h:224
>> +} // namespace WTF
> 
> This should be namespace WTF

It is :-)

>> Source/WebCore/html/track/TrackBase.cpp:38
>> +using namespace WTF;
> 
> Many WTF header files end with using WTF::Something;
> Let's do that instead of this.
> Then we can also replace the WTF::Logger with Logger

Good idea, thanks!

[Eric Carlson]

Created attachment 328827 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 328827 [details]
Patch for landing

Clearing flags on attachment: 328827

Committed r225696: <https://trac.webkit.org/changeset/225696>