Bug 180549 - Fix erroneous ASSERT in DocumentThreadableLoader::didFail
Summary: Fix erroneous ASSERT in DocumentThreadableLoader::didFail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-07 14:47 PST by youenn fablet
Modified: 2017-12-07 15:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2017-12-07 14:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2017-12-07 14:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-07 14:47:41 PST 
It should check for resource request to be null and not for optional to be empty
Comment 1 youenn fablet 2017-12-07 14:54:17 PST 
Created attachment 328744 [details]
Patch
Comment 2 youenn fablet 2017-12-07 14:54:53 PST 
Created attachment 328745 [details]
Patch
Comment 3 WebKit Commit Bot 2017-12-07 15:30:37 PST 
Comment on attachment 328745 [details]
Patch

Clearing flags on attachment: 328745

Committed r225648: <https://trac.webkit.org/changeset/225648>
Comment 4 WebKit Commit Bot 2017-12-07 15:30:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-07 15:31:37 PST 
<rdar://problem/35921238>