Bug 180546 - CacheStorage Cache should not remove any disk entry when clearing its memory representation
Summary: CacheStorage Cache should not remove any disk entry when clearing its memory ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-07 13:25 PST by youenn fablet
Modified: 2017-12-07 15:18 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2017-12-07 13:26 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-07 13:25:53 PST
CacheStorage Cache should not remove any disk entry when clearing its memory representation.
Comment 1 youenn fablet 2017-12-07 13:26:57 PST
Created attachment 328729 [details]
Patch
Comment 2 youenn fablet 2017-12-07 14:13:42 PST
This patch is tested manually by going to website using service worker:
- load a page
- ensure working in offline mode
- close page and wait for service worker to be terminated
- reload page and web site should work/cache API should have all its data

It will be good to add an API tests once we have a server running for these.
Comment 3 WebKit Commit Bot 2017-12-07 15:17:59 PST
Comment on attachment 328729 [details]
Patch

Clearing flags on attachment: 328729

Committed r225646: <https://trac.webkit.org/changeset/225646>
Comment 4 WebKit Commit Bot 2017-12-07 15:18:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-07 15:18:27 PST
<rdar://problem/35920909>