Bug 180540 - Use fastAlignedFree to free aligned memory.
Summary: Use fastAlignedFree to free aligned memory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-07 12:45 PST by Per Arne Vollan
Modified: 2017-12-07 16:20 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2017-12-07 12:46 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.56 MB, application/zip)
2017-12-07 13:56 PST, EWS Watchlist 		no flags Details
Patch (1.18 KB, patch)
2017-12-07 14:14 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-12-07 12:45:47 PST 
When memory is allocated with tryFastAlignedMalloc, I believe we should use fastAlignedFree to free the memory.
Comment 1 Per Arne Vollan 2017-12-07 12:46:49 PST 
Created attachment 328717 [details]
Patch
Comment 2 Saam Barati 2017-12-07 12:50:59 PST 
Comment on attachment 328717 [details]
Patch

r=me
Comment 3 EWS Watchlist 2017-12-07 13:56:41 PST 
Comment on attachment 328717 [details]
Patch

Attachment 328717 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5533377

New failing tests:
http/tests/workers/service/Client-properties-auxiliary.html
Comment 4 EWS Watchlist 2017-12-07 13:56:42 PST 
Created attachment 328734 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Per Arne Vollan 2017-12-07 14:14:13 PST 
Created attachment 328740 [details]
Patch
Comment 6 Per Arne Vollan 2017-12-07 15:57:30 PST 
(In reply to Saam Barati from comment #2)
> Comment on attachment 328717 [details]
> Patch
> 
> r=me

Thanks for reviewing! It seems the mac-wk2 ews failure was a flaky failure. When I uploaded the patch a second time, it passed ews.
Comment 7 WebKit Commit Bot 2017-12-07 16:18:03 PST 
Comment on attachment 328717 [details]
Patch

Clearing flags on attachment: 328717

Committed r225652: <https://trac.webkit.org/changeset/225652>
Comment 8 WebKit Commit Bot 2017-12-07 16:18:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-12-07 16:20:50 PST 
<rdar://problem/35922728>