Bug 180534 – Activate IDB and WebSockets in service workers

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Activate IDB and WebSockets in service workers

[youenn fablet]

Created attachment 328702 [details]
Patch

[EWS Watchlist]

Attachment 328702 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Cannot we unskip the websocket in WPT?

[youenn fablet]

(In reply to Chris Dumez from comment #3)
> Cannot we unskip the websocket in WPT?

I can try but this test relies on WPT ws socket server.
One of the service worker web socket test is flaky due to certificate issues.

[youenn fablet]

(In reply to youenn fablet from comment #4)
> (In reply to Chris Dumez from comment #3)
> > Cannot we unskip the websocket in WPT?
> 
> I can try but this test relies on WPT ws socket server.
> One of the service worker web socket test is flaky due to certificate issues.

WPT test of web socket in service worker is running locally consistently (still failing though, getting an onerror event).
I will unskip it at landing time or in another version of this patch.

[youenn fablet]

Created attachment 328721 [details]
Patch for landing

[EWS Watchlist]

Attachment 328721 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 328721 [details]
Patch for landing

Rejecting attachment 328721 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 328721, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/5533024

[youenn fablet]

Created attachment 328723 [details]
Patch for landing

[EWS Watchlist]

Attachment 328723 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 328723 [details]
Patch for landing

Clearing flags on attachment: 328723

Committed r225644: <https://trac.webkit.org/changeset/225644>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35918045>