ServiceWorker Inspector: Use the SW's scope url for the remote inspection target metadata So if there are multiple SW's for a domain they can be distinguished based on their scoping.
Created attachment 328673 [details] [PATCH] Proposed Fix
Comment on attachment 328673 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=328673&action=review > Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h:49 > + String url() const override { return m_scopeURL; } Could be final and made private, as should name() probably. I also wonder whether url() could return a const String&. Would need to change RemoteInspectionTarget and maybe use emptyString().
(In reply to youenn fablet from comment #2) > Comment on attachment 328673 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328673&action=review > > > Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h:49 > > + String url() const override { return m_scopeURL; } > > Could be final and made private, as should name() probably. > > I also wonder whether url() could return a const String&. > Would need to change RemoteInspectionTarget and maybe use emptyString(). Good points. I'll do all of these in a follow-up at the same time.
<https://trac.webkit.org/r225633>
<rdar://problem/35913551>