Bug 180515 - Add logging for EditorState in RemoteLayerTree transactions
Summary: Add logging for EditorState in RemoteLayerTree transactions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 17:33 PST by Simon Fraser (smfr)
Modified: 2017-12-07 16:18 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.89 KB, patch)
2017-12-06 17:35 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-12-06 17:33:28 PST 
Add logging for EditorState in RemoteLayerTree transactions
Comment 1 Simon Fraser (smfr) 2017-12-06 17:35:32 PST 
Created attachment 328663 [details]
Patch
Comment 2 Wenson Hsieh 2017-12-06 18:42:18 PST 
Comment on attachment 328663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328663&action=review

> Source/WebKit/Shared/EditorState.cpp:240
> +    if (editorState.postLayoutData().typingAttributes != AttributeNone)

This probably should only try to dump post layout data if !isMissingPostLayoutData. Otherwise, it'll hit an assertion in debug builds.
Comment 3 Simon Fraser (smfr) 2017-12-07 16:16:42 PST 
https://trac.webkit.org/r225651
Comment 4 Radar WebKit Bug Importer 2017-12-07 16:18:52 PST 
<rdar://problem/35922667>