WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180515
Add logging for EditorState in RemoteLayerTree transactions
https://bugs.webkit.org/show_bug.cgi?id=180515
Summary
Add logging for EditorState in RemoteLayerTree transactions
Simon Fraser (smfr)
Reported
2017-12-06 17:33:28 PST
Add logging for EditorState in RemoteLayerTree transactions
Attachments
Patch
(8.89 KB, patch)
2017-12-06 17:35 PST
,
Simon Fraser (smfr)
wenson_hsieh
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2017-12-06 17:35:32 PST
Created
attachment 328663
[details]
Patch
Wenson Hsieh
Comment 2
2017-12-06 18:42:18 PST
Comment on
attachment 328663
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=328663&action=review
> Source/WebKit/Shared/EditorState.cpp:240 > + if (editorState.postLayoutData().typingAttributes != AttributeNone)
This probably should only try to dump post layout data if !isMissingPostLayoutData. Otherwise, it'll hit an assertion in debug builds.
Simon Fraser (smfr)
Comment 3
2017-12-07 16:16:42 PST
https://trac.webkit.org/r225651
Radar WebKit Bug Importer
Comment 4
2017-12-07 16:18:52 PST
<
rdar://problem/35922667
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug