Bug 180508 - Web Inspector: Styles Redesign: navigating away from empty value should remove CSS property
Summary: Web Inspector: Styles Redesign: navigating away from empty value should remov...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 15:13 PST by Nikita Vasilyev
Modified: 2017-12-12 22:20 PST (History)
4 users (show)

See Also:


Attachments
[Animated GIF] Bug (72.52 KB, image/gif)
2017-12-06 15:14 PST, Nikita Vasilyev
no flags Details
Patch (4.45 KB, patch)
2017-12-06 16:42 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Animated GIF] With patch applied (174.16 KB, image/gif)
2017-12-06 16:47 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-12-06 15:13:09 PST
Steps:
1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/no-trailing-semicolon.html
2. Inspect <body>
3. Click after "color: #333;" to add a new property.
4. Type "float".
5. Press Tab to navigate to the value field.
6. Press Enter or Tab.

Actual:
"float: ;" stays visible.

Expected:
"float: ;" should get removed.

Notes:
This worked fine a few weeks ago.
Clicking on the white space anywhere in Web Inspector UI to discard the property still works as expected.

<rdar://problem/35476584>
Comment 1 Nikita Vasilyev 2017-12-06 15:14:07 PST
Created attachment 328637 [details]
[Animated GIF] Bug
Comment 2 Nikita Vasilyev 2017-12-06 16:42:18 PST
Created attachment 328651 [details]
Patch
Comment 3 Nikita Vasilyev 2017-12-06 16:47:35 PST
Created attachment 328652 [details]
[Animated GIF] With patch applied
Comment 4 Nikita Vasilyev 2017-12-07 12:22:15 PST
Comment on attachment 328651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328651&action=review

> Source/WebInspectorUI/ChangeLog:13
> +        Remove a property when navigating away from it (e.g. to the next/previous property,
> +        or outside of the styles panel entirely) and either its name or value is empty:
> +
> +            color: [ ]->
> +            <-[ ]: red
> +            <-[color]:

[ ] here is focus.
-> and <- is where focus moves.
Comment 5 Devin Rousso 2017-12-12 22:00:18 PST
Comment on attachment 328651 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-12-12 22:20:00 PST
Comment on attachment 328651 [details]
Patch

Clearing flags on attachment: 328651

Committed r225839: <https://trac.webkit.org/changeset/225839>
Comment 7 WebKit Commit Bot 2017-12-12 22:20:02 PST
All reviewed patches have been landed.  Closing bug.