Bug 180505 - Web Inspector: Canvas: spurious warnings shown for commands that changed pixel contents
Summary: Web Inspector: Canvas: spurious warnings shown for commands that changed pixe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 14:07 PST by Matt Baker
Modified: 2017-12-06 16:03 PST (History)
5 users (show)

See Also:


Attachments
[Image] Recording w/ bogus warnings (332.55 KB, image/png)
2017-12-06 14:09 PST, Matt Baker
no flags Details
Patch (2.76 KB, patch)
2017-12-06 14:55 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-12-06 14:07:37 PST
Summary:
Spurious warnings shown for commands that changed pixel contents.

Steps to Reproduce:
1. Goto https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations
2. Record the "stopwatch" canvas animation
3. Filter to only show drawing commands
  => Every command includes a warning that "This action causes no visual change"
Comment 1 Matt Baker 2017-12-06 14:09:28 PST
Created attachment 328625 [details]
[Image] Recording w/ bogus warnings
Comment 2 Radar WebKit Bug Importer 2017-12-06 14:10:09 PST
<rdar://problem/35891651>
Comment 3 Brian Burg 2017-12-06 14:46:28 PST
Devin, can you take a look?
Comment 4 Devin Rousso 2017-12-06 14:55:39 PST
Created attachment 328635 [details]
Patch
Comment 5 Devin Rousso 2017-12-06 14:56:16 PST
(In reply to Brian Burg from comment #3)
> Devin, can you take a look?
My fault.  I forgot a `!` 😁
Comment 6 Brian Burg 2017-12-06 15:24:17 PST
Comment on attachment 328635 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2017-12-06 16:02:58 PST
Comment on attachment 328635 [details]
Patch

Clearing flags on attachment: 328635

Committed r225602: <https://trac.webkit.org/changeset/225602>
Comment 8 WebKit Commit Bot 2017-12-06 16:03:00 PST
All reviewed patches have been landed.  Closing bug.