Bug 180502 - Move all tests under http/tests/loading/resourceLoadStatistics/ to http/tests/resourceLoadStatistics/ and remove expected failures
Summary: Move all tests under http/tests/loading/resourceLoadStatistics/ to http/tests...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 13:57 PST by John Wilander
Modified: 2017-12-07 12:09 PST (History)
8 users (show)

See Also:


Attachments
Patch (268.95 KB, patch)
2017-12-06 14:07 PST, John Wilander
no flags Details | Formatted Diff | Diff
Patch (269.13 KB, patch)
2017-12-06 14:18 PST, John Wilander
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (3.29 MB, application/zip)
2017-12-06 15:35 PST, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.19 MB, application/zip)
2017-12-06 15:57 PST, Build Bot
no flags Details
Patch (270.36 KB, patch)
2017-12-06 16:16 PST, John Wilander
no flags Details | Formatted Diff | Diff
Patch (270.81 KB, patch)
2017-12-06 17:25 PST, John Wilander
no flags Details | Formatted Diff | Diff
Patch for landing (351.74 KB, patch)
2017-12-07 09:44 PST, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-12-06 13:57:23 PST
Having the resource load statistics tests under http/tests/loading/ was a mistake since it causes text diff flakiness with load order of frames. We should move all tests one step up, under http/tests/resourceLoadStatistics/, work them through, and mark them [ Pass ].
Comment 1 Radar WebKit Bug Importer 2017-12-06 13:58:04 PST
<rdar://problem/35891216>
Comment 2 John Wilander 2017-12-06 14:07:38 PST
Created attachment 328624 [details]
Patch
Comment 3 John Wilander 2017-12-06 14:18:14 PST
Created attachment 328627 [details]
Patch
Comment 4 Build Bot 2017-12-06 15:35:09 PST
Comment on attachment 328627 [details]
Patch

Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5521095

New failing tests:
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html
http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html
http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
Comment 5 Build Bot 2017-12-06 15:35:11 PST
Created attachment 328639 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-12-06 15:57:04 PST
Comment on attachment 328627 [details]
Patch

Attachment 328627 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5521186

New failing tests:
http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html
http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html
Comment 7 Build Bot 2017-12-06 15:57:06 PST
Created attachment 328642 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 8 John Wilander 2017-12-06 16:16:45 PST
Created attachment 328645 [details]
Patch
Comment 9 John Wilander 2017-12-06 16:18:10 PST
(In reply to Build Bot from comment #4)
> Comment on attachment 328627 [details]
> Patch
> 
> Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5521095
> 
> New failing tests:
> http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-
> deletion.html
> http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-
> interaction.html
> http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-
> interaction.html
> http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-
> partitioning-timeout.html

These were failing because cookie partitioning is not a thing on El Cap.
Comment 10 John Wilander 2017-12-06 17:25:58 PST
Created attachment 328660 [details]
Patch
Comment 11 John Wilander 2017-12-06 17:27:46 PST
Skipped …

http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html
http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html

… on iOS since UIHelper.activateAt() doesn't produce a user gesture that ITP captures on iOS. This is the reason why we also skip http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html on iOS.
Comment 12 Brent Fulgham 2017-12-06 20:00:50 PST
Comment on attachment 328660 [details]
Patch

Did you use "svn mv" to relocate these files? We want to make sure we retain svn history.

r=me if you did 'svn mv'
Comment 13 John Wilander 2017-12-07 09:44:59 PST
Created attachment 328699 [details]
Patch for landing
Comment 14 John Wilander 2017-12-07 09:45:53 PST
(In reply to Brent Fulgham from comment #12)
> Comment on attachment 328660 [details]
> Patch
> 
> Did you use "svn mv" to relocate these files? We want to make sure we retain
> svn history.
> 
> r=me if you did 'svn mv'

I hadn't, but now I have. Thanks for pointing this out.
Comment 15 WebKit Commit Bot 2017-12-07 12:09:32 PST
Comment on attachment 328699 [details]
Patch for landing

Clearing flags on attachment: 328699

Committed r225640: <https://trac.webkit.org/changeset/225640>
Comment 16 WebKit Commit Bot 2017-12-07 12:09:34 PST
All reviewed patches have been landed.  Closing bug.