Bug 180502 – Move all tests under http/tests/loading/resourceLoadStatistics/ to http/tests/resourceLoadStatistics/ and remove expected failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[John Wilander]

Having the resource load statistics tests under http/tests/loading/ was a mistake since it causes text diff flakiness with load order of frames. We should move all tests one step up, under http/tests/resourceLoadStatistics/, work them through, and mark them [ Pass ].

[Radar WebKit Bug Importer]

<rdar://problem/35891216>

[John Wilander]

Created attachment 328624 [details]
Patch

[John Wilander]

Created attachment 328627 [details]
Patch

[EWS Watchlist]

Comment on attachment 328627 [details]
Patch

Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5521095

New failing tests:
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html
http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html
http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html

[EWS Watchlist]

Created attachment 328639 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328627 [details]
Patch

Attachment 328627 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5521186

New failing tests:
http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html
http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html

[EWS Watchlist]

Created attachment 328642 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[John Wilander]

Created attachment 328645 [details]
Patch

[John Wilander]

(In reply to Build Bot from comment #4)
> Comment on attachment 328627 [details]
> Patch
> 
> Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5521095
> 
> New failing tests:
> http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-
> deletion.html
> http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-
> interaction.html
> http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-
> interaction.html
> http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-
> partitioning-timeout.html

These were failing because cookie partitioning is not a thing on El Cap.

[John Wilander]

Created attachment 328660 [details]
Patch

[John Wilander]

Skipped …

http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html
http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html

… on iOS since UIHelper.activateAt() doesn't produce a user gesture that ITP captures on iOS. This is the reason why we also skip http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html on iOS.

[Brent Fulgham]

Comment on attachment 328660 [details]
Patch

Did you use "svn mv" to relocate these files? We want to make sure we retain svn history.

r=me if you did 'svn mv'

[John Wilander]

Created attachment 328699 [details]
Patch for landing

[John Wilander]

(In reply to Brent Fulgham from comment #12)
> Comment on attachment 328660 [details]
> Patch
> 
> Did you use "svn mv" to relocate these files? We want to make sure we retain
> svn history.
> 
> r=me if you did 'svn mv'

I hadn't, but now I have. Thanks for pointing this out.

[WebKit Commit Bot]

Comment on attachment 328699 [details]
Patch for landing

Clearing flags on attachment: 328699

Committed r225640: <https://trac.webkit.org/changeset/225640>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.