Bug 180495 - [WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Summary: [WTF] Remove XXXLockBase since constexpr constructor can initialize static va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 12:34 PST by Yusuke Suzuki
Modified: 2017-12-11 23:39 PST (History)
13 users (show)

See Also:

Attachments
Patch (15.69 KB, patch)
2017-12-06 12:37 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (18.75 KB, patch)
2017-12-06 13:15 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (15.69 KB, patch)
2017-12-06 14:00 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-06 12:34:33 PST 
[WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Comment 1 Yusuke Suzuki 2017-12-06 12:37:09 PST 
Created attachment 328607 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-06 12:44:27 PST 
We will extend it for bmalloc.
Comment 3 Yusuke Suzuki 2017-12-06 13:15:27 PST 
Created attachment 328613 [details]
Patch
Comment 4 Yusuke Suzuki 2017-12-06 14:00:05 PST 
Hm, in the meantime, I disable bmalloc's change.
Comment 5 Yusuke Suzuki 2017-12-06 14:00:27 PST 
Created attachment 328623 [details]
Patch
Comment 6 Mark Lam 2017-12-06 14:28:12 PST 
Comment on attachment 328623 [details]
Patch

Very nice.  r=me
Comment 7 Yusuke Suzuki 2017-12-06 19:31:28 PST 
Comment on attachment 328623 [details]
Patch

Thanks!
Comment 8 WebKit Commit Bot 2017-12-06 19:52:12 PST 
Comment on attachment 328623 [details]
Patch

Clearing flags on attachment: 328623

Committed r225617: <https://trac.webkit.org/changeset/225617>
Comment 9 WebKit Commit Bot 2017-12-06 19:52:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-06 19:53:37 PST 
<rdar://problem/35900197>