media/event-queue-crash.html is a flaky failure on macOS. According to the dashboard it has flaked on High Sierra Release, Sierra Debug WK1, and El Capitan Release WK2: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fevent-queue-crash.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r225575%20(1576)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1576 There isn't a clear regression point on the dashboard. Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: line 34: SyntaxError: Unexpected token '}'. Expected '(' to start an 'if' condition. When an element containing video is removed, WebKit should not crash. PASS. WebKit didn't crash.
<rdar://problem/35914377>
Matt, is this reproducible?
Yes, I was able to reproduce the failure on High Sierra however I had to run this multiple times to get the failure: run-webkit-tests media/event-queue-crash.html --no-retry-failure --verbose --iterations=50 -f -g
Created attachment 330978 [details] Patch
Created attachment 331056 [details] Patch
Comment on attachment 331056 [details] Patch Clearing flags on attachment: 331056 Committed r226785: <https://trac.webkit.org/changeset/226785>
All reviewed patches have been landed. Closing bug.
Re-baselined test in: https://trac.webkit.org/changeset/226798/webkit