Bug 180492 – We need to grab the JSLock in InjectedBundle::createWebDataFromUint8Array

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 328682 [details]
patch

Let's see if this builds. I haven't tried locally.

[Alex Christensen]

Comment on attachment 328682 [details]
patch

Please give a radar, a reason, or even better: a test that used to do something bad and now does something good.

[Saam Barati]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 328682 [details]
> patch
> 
> Please give a radar, a reason, or even better: a test that used to do
> something bad and now does something good.

Ryan pointed out that a test is already failing because of this.
See:
https://bugs.webkit.org/show_bug.cgi?id=180438
and
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r225440%20(4421)/webaudio/audiobuffersource-crash-log.txt
Is that enough?

I'm happy to add this reason to the changelog:
```
WKBundleCreateWKDataFromUInt8Array may allocate from the JS heap. To do so, you must be holding the JSLock.
```

[Alex Christensen]

Please add that to the ChangeLog, and also move the change to InjectedBundle::createWebDataFromUint8Array instead of at the API layer in case we add something else that calls that.

[Saam Barati]

Created attachment 328748 [details]
patch

[WebKit Commit Bot]

Comment on attachment 328748 [details]
patch

Clearing flags on attachment: 328748

Committed r225658: <https://trac.webkit.org/changeset/225658>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35924114>