Created attachment 328682 [details]
Let's see if this builds. I haven't tried locally.
Comment on attachment 328682 [details]
Please give a radar, a reason, or even better: a test that used to do something bad and now does something good.
(In reply to Alex Christensen from comment #2)
> Comment on attachment 328682 [details]
> Please give a radar, a reason, or even better: a test that used to do
> something bad and now does something good.
Ryan pointed out that a test is already failing because of this.
Is that enough?
I'm happy to add this reason to the changelog:
WKBundleCreateWKDataFromUInt8Array may allocate from the JS heap. To do so, you must be holding the JSLock.
Please add that to the ChangeLog, and also move the change to InjectedBundle::createWebDataFromUint8Array instead of at the API layer in case we add something else that calls that.
Created attachment 328748 [details]
Comment on attachment 328748 [details]
Clearing flags on attachment: 328748
Committed r225658: <https://trac.webkit.org/changeset/225658>
All reviewed patches have been landed. Closing bug.