Bug 180486 – [EME] Possible deadlock when aborting a SourceBufferPrivateAVFObjC append operation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[EME] Possible deadlock when aborting a SourceBufferPrivateAVFObjC append operation

[Jer Noble]

Created attachment 328592 [details]
Patch

[EWS Watchlist]

Comment on attachment 328592 [details]
Patch

Attachment 328592 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5518010

New failing tests:
webrtc/video-replace-muted-track.html

[EWS Watchlist]

Created attachment 328605 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Jer Noble]

(In reply to Build Bot from comment #3)
> Created attachment 328605 [details]
> Archive of layout-test-results from ews105 for mac-elcapitan-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-wk2-ews.
> Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

This test is a flakey failure locally even without my patch.

[Eric Carlson]

Comment on attachment 328592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328592&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:222
> +        if (!dispatch_semaphore_wait(_abortSemaphore.get(), dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_MSEC * 100))) {
> +            dispatch_semaphore_signal(_abortSemaphore.get());

Nit: why abortSemaphore rather than _abortSemaphore?

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:243
> +        if (!dispatch_semaphore_wait(_abortSemaphore.get(), dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_MSEC * 100))) {
> +            dispatch_semaphore_signal(_abortSemaphore.get());

Ditto.

[WebKit Commit Bot]

Comment on attachment 328592 [details]
Patch

Clearing flags on attachment: 328592

Committed r225635: <https://trac.webkit.org/changeset/225635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35914294>