Bug 180478 - StartFetch should take a ServiceWorkerIdentifier
Summary: StartFetch should take a ServiceWorkerIdentifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-06 09:01 PST by youenn fablet
Modified: 2017-12-07 18:34 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.33 KB, patch)
2017-12-06 09:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.34 KB, patch)
2017-12-06 12:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (13.80 KB, patch)
2017-12-07 18:00 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-06 09:01:36 PST 
Currently it takes an optional ServiceWorkerIdentifier which is not needed right now.
Comment 1 youenn fablet 2017-12-06 09:06:25 PST 
Created attachment 328576 [details]
Patch
Comment 2 Brady Eidson 2017-12-06 12:55:45 PST 
Comment on attachment 328576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328576&action=review

> Source/WebKit/ChangeLog:11
> +        In the case,there is a problem in running the service worker at start fetch time,

Missing space after comma
Comment 3 youenn fablet 2017-12-06 12:57:44 PST 
Created attachment 328612 [details]
Patch for landing
Comment 4 youenn fablet 2017-12-07 18:00:02 PST 
Created attachment 328766 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-12-07 18:33:39 PST 
Comment on attachment 328766 [details]
Patch for landing

Clearing flags on attachment: 328766

Committed r225665: <https://trac.webkit.org/changeset/225665>
Comment 6 WebKit Commit Bot 2017-12-07 18:33:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-07 18:34:46 PST 
<rdar://problem/35925781>