Bug 180473 – Make GraphicsLayer::dumpProperties dump m_offsetFromRenderer

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Frédéric Wang (:fredw)]

.

[Frédéric Wang (:fredw)]

Created attachment 328566 [details]
WIP Patch

[Ali Juma]

Comment on attachment 328566 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328566&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:721
> +    if (!m_offsetFromRenderer.isEmpty())

It might be a good idea to make this conditional on a LayerTreeAsTextBehavior flag to avoid having to rebaseline a large number of existing tests.

[EWS Watchlist]

Comment on attachment 328566 [details]
WIP Patch

Attachment 328566 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5515072

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 328567 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Comment on attachment 328566 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328566&action=review

>> Source/WebCore/platform/graphics/GraphicsLayer.cpp:721
>> +    if (!m_offsetFromRenderer.isEmpty())
> 
> It might be a good idea to make this conditional on a LayerTreeAsTextBehavior flag to avoid having to rebaseline a large number of existing tests.

Maybe I was not sure.

In any case, the condition is wrong, it should isZero() not isEmpty().

[EWS Watchlist]

Comment on attachment 328566 [details]
WIP Patch

Attachment 328566 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5515169

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 328568 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328566 [details]
WIP Patch

Attachment 328566 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5515191

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 328571 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 328566 [details]
WIP Patch

Attachment 328566 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5515223

New failing tests:
compositing/geometry/bounds-ignores-hidden.html
compositing/layer-creation/overlap-animation-clipping.html
compositing/visible-rect/3d-transform-style.html
compositing/tiling/backface-preserve-3d-tiled.html
compositing/geometry/foreground-layer.html
compositing/geometry/bounds-ignores-hidden-composited-descendant.html
compositing/geometry/clip-inside.html
compositing/visible-rect/clipped-visible-rect.html
compositing/visible-rect/2d-transformed.html
compositing/images/clip-on-directly-composited-image.html
compositing/geometry/clip.html
compositing/backing/no-backing-for-clip-overlap.html
compositing/visible-rect/3d-transformed.html
compositing/visible-rect/animated-from-none.html
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
compositing/visible-rect/nested-transform.html
compositing/geometry/bounds-ignores-hidden-dynamic.html
compositing/layer-creation/overlap-animation.html
compositing/visible-rect/coverage-clipped.html
compositing/layer-creation/fixed-position-under-transform.html
compositing/tiling/transform-origin-tiled.html
compositing/layer-creation/overlap-transforms.html
compositing/tiling/tiled-reflection-inwindow.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/overflow/clip-descendents.html
compositing/visible-rect/animated.html
compositing/backing/no-backing-for-clip.html

[EWS Watchlist]

Created attachment 328572 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 328698 [details]
Patch (WIP)

[EWS Watchlist]

Comment on attachment 328698 [details]
Patch (WIP)

Attachment 328698 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5530999

New failing tests:
compositing/tiling/transform-origin-tiled.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html
compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/tiled-reflection-inwindow.html
compositing/contents-opaque/control-layer.html
compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

[EWS Watchlist]

Created attachment 328703 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328698 [details]
Patch (WIP)

Attachment 328698 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5531071

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/contents-opaque/control-layer.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328705 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328698 [details]
Patch (WIP)

Attachment 328698 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5531104

New failing tests:
compositing/ios/overflow-scroll-touch-tiles.html
compositing/tiling/tiled-mask-inwindow.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328707 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 328698 [details]
Patch (WIP)

Attachment 328698 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5531151

New failing tests:
compositing/tiling/transform-origin-tiled.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html
compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/tiled-reflection-inwindow.html
compositing/contents-opaque/control-layer.html
compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

[EWS Watchlist]

Created attachment 328710 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 328712 [details]
Patch

[zalan]

Comment on attachment 328712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328712&action=review

> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
> -  (bounds 800.00 897.00)
> +  (bounds 800.00 925.00)
>    (children 1
>      (GraphicsLayer
> -      (bounds 800.00 897.00)
> +      (bounds 800.00 925.00)
>        (contentsOpaque 1)

It looks like it's more than just debug info.

> LayoutTests/compositing/tiling/tiled-reflection-inwindow-expected.txt:63
> -  (bounds 913.00 1206.00)
> +  (bounds 913.00 1221.00)
>    (children 1
>      (GraphicsLayer
> -      (bounds 913.00 1206.00)
> +      (bounds 913.00 1221.00)

This too.

> LayoutTests/platform/ios-wk2/compositing/tiling/tiled-reflection-inwindow-expected.txt:63
> -  (bounds 913.00 1149.00)
> +  (bounds 913.00 1163.00)
>    (children 1
>      (GraphicsLayer
> -      (bounds 913.00 1149.00)
> +      (bounds 913.00 1163.00)

?

> LayoutTests/platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt:59
> -  (bounds 913.00 1146.00)
> +  (bounds 913.00 1161.00)
>    (children 1
>      (GraphicsLayer
> -      (bounds 913.00 1146.00)
> +      (bounds 913.00 1161.00)

?

[Frédéric Wang (:fredw)]

Comment on attachment 328712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328712&action=review

>> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
>>        (contentsOpaque 1)
> 
> It looks like it's more than just debug info.

Well, if you read the C++ change, it should definitely only be debug info. I guess these diffs came from another change unrelated to that patch.

[Frédéric Wang (:fredw)]

Created attachment 328719 [details]
Patch

[EWS Watchlist]

Comment on attachment 328719 [details]
Patch

Attachment 328719 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5533648

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328737 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328719 [details]
Patch

Attachment 328719 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5533546

New failing tests:
compositing/ios/overflow-scroll-touch-tiles.html
compositing/tiling/tiled-mask-inwindow.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328738 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 328719 [details]
Patch

Attachment 328719 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5533540

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328741 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328719 [details]
Patch

Attachment 328719 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5534503

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/tiled-reflection-inwindow.html

[EWS Watchlist]

Created attachment 328746 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 328807 [details]
Patch

[EWS Watchlist]

Comment on attachment 328807 [details]
Patch

Attachment 328807 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5544823

New failing tests:
compositing/tiling/rotated-tiled-clamped.html

[EWS Watchlist]

Created attachment 328812 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 328807 [details]
Patch

Attachment 328807 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5544861

New failing tests:
compositing/tiling/tiled-mask-inwindow.html

[EWS Watchlist]

Created attachment 328813 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 328807 [details]
Patch

Attachment 328807 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5544851

New failing tests:
compositing/tiling/rotated-tiled-clamped.html

[EWS Watchlist]

Created attachment 328814 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 328976 [details]
Patch

[Antonio Gomes]

(In reply to Frédéric Wang (:fredw) from comment #23)
> Comment on attachment 328712 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328712&action=review
> 
> >> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
> >>        (contentsOpaque 1)
> > 
> > It looks like it's more than just debug info.
> 
> Well, if you read the C++ change, it should definitely only be debug info. I
> guess these diffs came from another change unrelated to that patch.

Frederic added a reason for it in the ChangeLog.

In summary: "the text output is changed. This output is put in a <div>to appear in the dumped tree. However, that makes the corresponding graphics layer taller."

[Frédéric Wang (:fredw)]

Created attachment 329335 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 329335 [details]
Patch for landing

Clearing flags on attachment: 329335

Committed r225897: <https://trac.webkit.org/changeset/225897>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36043897>