Bug 180456 - InferredType should not use UnconditionalFinalizer
Summary: InferredType should not use UnconditionalFinalizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 180248
  Show dependency treegraph
 
Reported: 2017-12-05 16:25 PST by Filip Pizlo
Modified: 2017-12-09 11:49 PST (History)
6 users (show)

See Also:


Attachments
it's a start (36.22 KB, patch)
2017-12-05 16:27 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (37.56 KB, patch)
2017-12-05 17:32 PST, Filip Pizlo
sbarati: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.88 MB, application/zip)
2017-12-05 18:41 PST, Build Bot
no flags Details
patch for landing (38.07 KB, patch)
2017-12-05 19:08 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-12-05 16:25:43 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2017-12-05 16:27:10 PST
Created attachment 328523 [details]
it's a start
Comment 2 Filip Pizlo 2017-12-05 17:32:49 PST
Created attachment 328538 [details]
the patch
Comment 3 Saam Barati 2017-12-05 17:39:35 PST
Comment on attachment 328538 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review

> Source/JavaScriptCore/runtime/InferredType.cpp:90
> +    if (inferredType->m_structure)
> +        visitor.append(inferredType->m_structure);

Doesn't append already do a null check for you?
Comment 4 Filip Pizlo 2017-12-05 17:42:25 PST
(In reply to Saam Barati from comment #3)
> Comment on attachment 328538 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328538&action=review
> 
> > Source/JavaScriptCore/runtime/InferredType.cpp:90
> > +    if (inferredType->m_structure)
> > +        visitor.append(inferredType->m_structure);
> 
> Doesn't append already do a null check for you?

Yeah you're right!
Comment 5 Build Bot 2017-12-05 18:41:22 PST
Comment on attachment 328538 [details]
the patch

Attachment 328538 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5508914

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2017-12-05 18:41:23 PST
Created attachment 328543 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Filip Pizlo 2017-12-05 19:08:59 PST
Created attachment 328546 [details]
patch for landing

This fixes some crashes
Comment 8 Filip Pizlo 2017-12-09 11:48:26 PST
Landed in https://trac.webkit.org/changeset/225725/webkit
Comment 9 Radar WebKit Bug Importer 2017-12-09 11:49:26 PST
<rdar://problem/35953018>