Bug 180456 – InferredType should not use UnconditionalFinalizer

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 328523 [details]
it's a start

[Filip Pizlo]

Created attachment 328538 [details]
the patch

[Saam Barati]

Comment on attachment 328538 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review

> Source/JavaScriptCore/runtime/InferredType.cpp:90
> +    if (inferredType->m_structure)
> +        visitor.append(inferredType->m_structure);

Doesn't append already do a null check for you?

[Filip Pizlo]

(In reply to Saam Barati from comment #3)
> Comment on attachment 328538 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328538&action=review
> 
> > Source/JavaScriptCore/runtime/InferredType.cpp:90
> > +    if (inferredType->m_structure)
> > +        visitor.append(inferredType->m_structure);
> 
> Doesn't append already do a null check for you?

Yeah you're right!

[EWS Watchlist]

Comment on attachment 328538 [details]
the patch

Attachment 328538 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5508914

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 328543 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Filip Pizlo]

Created attachment 328546 [details]
patch for landing

This fixes some crashes

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/225725/webkit

[Radar WebKit Bug Importer]

<rdar://problem/35953018>