Bug 180450 - ServiceWorkerGlobalScope prototype chain should be immutable
Summary: ServiceWorkerGlobalScope prototype chain should be immutable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-05 14:56 PST by Chris Dumez
Modified: 2017-12-06 16:28 PST (History)
10 users (show)

See Also:


Attachments
Patch (24.63 KB, patch)
2017-12-05 16:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (26.27 KB, patch)
2017-12-05 20:15 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-05 14:56:08 PST
ServiceWorkerGlobalScope prototype chain should be immutable. Covered by:
imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
Comment 1 Chris Dumez 2017-12-05 16:49:53 PST
Created attachment 328525 [details]
Patch
Comment 2 youenn fablet 2017-12-05 18:37:09 PST
Comment on attachment 328525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328525&action=review

> Source/WebCore/ChangeLog:9
> +        do what we do for DOMWindow. This is covered by a web-platform-test

s/do/to

> Source/WebCore/workers/DedicatedWorkerGlobalScope.idl:37
> +    IsImmutablePrototypeExoticObjectOnPrototype,

It seems we have no tests for this change.
We should probably import WPT workers test suite to cover this (and maybe much more!).
Comment 3 youenn fablet 2017-12-05 19:15:02 PST
Filed bug 180464 for wpt worker test suite
Comment 4 Chris Dumez 2017-12-05 20:15:21 PST
Created attachment 328548 [details]
Patch
Comment 5 WebKit Commit Bot 2017-12-05 20:47:03 PST
Comment on attachment 328548 [details]
Patch

Clearing flags on attachment: 328548

Committed r225566: <https://trac.webkit.org/changeset/225566>
Comment 6 WebKit Commit Bot 2017-12-05 20:47:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-06 16:28:32 PST
<rdar://problem/35896053>
Comment 8 Radar WebKit Bug Importer 2017-12-06 16:28:38 PST
<rdar://problem/35896057>