RESOLVED FIXED 180450
ServiceWorkerGlobalScope prototype chain should be immutable 
https://bugs.webkit.org/show_bug.cgi?id=180450
Summary ServiceWorkerGlobalScope prototype chain should be immutable
Chris Dumez
Reported 2017-12-05 14:56:08 PST
ServiceWorkerGlobalScope prototype chain should be immutable. Covered by: imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
Attachments
Patch (24.63 KB, patch)
2017-12-05 16:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.27 KB, patch)
2017-12-05 20:15 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-12-05 16:49:53 PST
Created attachment 328525 [details] Patch
youenn fablet
Comment 2 2017-12-05 18:37:09 PST
Comment on attachment 328525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328525&action=review > Source/WebCore/ChangeLog:9 > + do what we do for DOMWindow. This is covered by a web-platform-test s/do/to > Source/WebCore/workers/DedicatedWorkerGlobalScope.idl:37 > + IsImmutablePrototypeExoticObjectOnPrototype, It seems we have no tests for this change. We should probably import WPT workers test suite to cover this (and maybe much more!).
youenn fablet
Comment 3 2017-12-05 19:15:02 PST
Filed bug 180464 for wpt worker test suite
Chris Dumez
Comment 4 2017-12-05 20:15:21 PST
Created attachment 328548 [details] Patch
WebKit Commit Bot
Comment 5 2017-12-05 20:47:03 PST
Comment on attachment 328548 [details] Patch Clearing flags on attachment: 328548 Committed r225566: <https://trac.webkit.org/changeset/225566>
WebKit Commit Bot
Comment 6 2017-12-05 20:47:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-06 16:28:32 PST
<rdar://problem/35896053>
Radar WebKit Bug Importer
Comment 8 2017-12-06 16:28:38 PST
<rdar://problem/35896057>
Note You need to log in before you can comment on or make changes to this bug.