Bug 180449 - Use WTF::RecursiveLockAdapter instead of using pthread_mutex_t with recursive lock option
Summary: Use WTF::RecursiveLockAdapter instead of using pthread_mutex_t with recursive...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-05 14:51 PST by Yusuke Suzuki
Modified: 2017-12-07 19:06 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2017-12-05 14:52 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (4.00 KB, patch)
2017-12-07 04:49 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-05 14:51:44 PST 
Use WTF::RecursiveLockAdapter instead of using pthread_mutex_t with recursive lock option
Comment 1 Yusuke Suzuki 2017-12-05 14:52:35 PST 
Created attachment 328505 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-07 04:49:29 PST 
Created attachment 328690 [details]
Patch
Comment 3 Mark Lam 2017-12-07 10:28:24 PST 
Comment on attachment 328690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328690&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Use WTF::RecursiveLockAdapter<StaticLock> instead. We can remove pthred_mutex_xxx,

typo: /pthred_mutex_xxx/pthread_mutex_xxx/
Comment 4 Yusuke Suzuki 2017-12-07 18:18:49 PST 
Comment on attachment 328690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328690&action=review

>> Source/WebCore/ChangeLog:8
>> +        Use WTF::RecursiveLockAdapter<StaticLock> instead. We can remove pthred_mutex_xxx,
> 
> typo: /pthred_mutex_xxx/pthread_mutex_xxx/

Thanks, fixed.
Comment 5 Yusuke Suzuki 2017-12-07 19:02:31 PST 
Committed r225667: <https://trac.webkit.org/changeset/225667>
Comment 6 Radar WebKit Bug Importer 2017-12-07 19:06:26 PST 
<rdar://problem/35926300>