It looks like it may have caused a regression, but I can't repro it. For now just don't checksum, and we can revisit later when I have time. Let's see what perf bots say.
<rdar://problem/35156628>
Created attachment 328494 [details] patch
Attachment 328494 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/wasm/WasmNameSection.h:48: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 328494 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=328494&action=review r=me > Source/JavaScriptCore/runtime/Options.h:481 > + v(bool, eagerlyHashWebAssemblyModules, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \ nit: I'd name this starting with "use" to be consistent with many of our other options. Maybe: useEagerWebAssemblyModuleHashing?
Created attachment 328498 [details] patch Address comments.
Comment on attachment 328498 [details] patch Clearing flags on attachment: 328498 Committed r225550: <https://trac.webkit.org/changeset/225550>
All reviewed patches have been landed. Closing bug.