Source\JavaScriptCore\assembler\testmasm.cpp(186): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
Created attachment 328482 [details] Patch
Comment on attachment 328482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review r=me with fix. > Source/JavaScriptCore/assembler/testmasm.cpp:186 > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); let's make it static_cast<size_t>(1). I think that is what we really want.
(In reply to Mark Lam from comment #2) > Comment on attachment 328482 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328482&action=review > > r=me with fix. > > > Source/JavaScriptCore/assembler/testmasm.cpp:186 > > + }), pointer + offset + (1ll << static_cast<int>(scale)) * length); > > let's make it static_cast<size_t>(1). I think that is what we really want. Thanks for reviewing! I will update before landing.
Committed r225536: <https://trac.webkit.org/changeset/225536/webkit>.
<rdar://problem/35863628>