Bug 180433 - Prefer ids and classes over tag names in selector filter
Summary: Prefer ids and classes over tag names in selector filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-05 10:54 PST by Antti Koivisto
Modified: 2017-12-06 14:24 PST (History)
7 users (show)

See Also:

Attachments
patch (8.16 KB, patch)
2017-12-05 11:00 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-12-05 10:54:25 PST 
There are only four slots in the filter and currently we just pick whatever identifiers we find traversing the selector from right to left. More specific selector types are on average more valuable (id > class > tag) so we should prefer them.
Comment 1 Radar WebKit Bug Importer 2017-12-05 10:57:41 PST 
<rdar://problem/35859103>
Comment 2 Antti Koivisto 2017-12-05 11:00:16 PST 
Created attachment 328471 [details]
patch
Comment 3 WebKit Commit Bot 2017-12-06 14:24:09 PST 
Comment on attachment 328471 [details]
patch

Clearing flags on attachment: 328471

Committed r225596: <https://trac.webkit.org/changeset/225596>
Comment 4 WebKit Commit Bot 2017-12-06 14:24:11 PST 
All reviewed patches have been landed.  Closing bug.