Bug 180432 - [build.webkit.org] Rename mastercfg_unittest to steps_unittest
Summary: [build.webkit.org] Rename mastercfg_unittest to steps_unittest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-05 10:30 PST by Aakash Jain
Modified: 2017-12-05 14:36 PST (History)
8 users (show)

See Also:


Attachments
Proposed patch (77.75 KB, patch)
2017-12-05 10:32 PST, Aakash Jain
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-12-05 10:30:09 PST
mastercfg_unittest.py does not test master.cfg, it tests steps.py. We should rename it to steps_unittest.py
Comment 1 Aakash Jain 2017-12-05 10:32:33 PST
Created attachment 328465 [details]
Proposed patch

Might need to re-base before landing because of other patches modifying same file.
Comment 2 EWS Watchlist 2017-12-05 10:35:05 PST
Attachment 328465 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:15:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:88:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:407:  whitespace before ':'  [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:413:  missing whitespace after ':'  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:105:  [RunJavaScriptCoreTestsTest.assertResults] Undefined variable 'RunJavaScriptCoreTests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:114:  [RunJavaScriptCoreTestsTest.test_no_regressions_old_output] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:120:  [RunJavaScriptCoreTestsTest.test_no_failure_new_output] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:125:  [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:130:  [RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:135:  [RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:139:  [RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:146:  [RunTest262TestsTest.assertResults] Undefined variable 'RunTest262Tests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:155:  [RunTest262TestsTest.test_no_regressions_output] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:162:  [RunTest262TestsTest.test_failure_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:171:  [RunTest262TestsTest.test_failures_output] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:185:  [RunLLINTCLoopTestsTest.assertResults] Undefined variable 'RunLLINTCLoopTests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:194:  [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:197:  [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:200:  [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:206:  [Run32bitJSCTestsTest.assertResults] Undefined variable 'Run32bitJSCTests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:215:  [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:218:  [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:221:  [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:228:  [RunUnitTestsTest.assertFailures] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:233:  [RunUnitTestsTest.assertFailures] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:237:  [RunUnitTestsTest.assertFailures] Undefined variable 'RunUnitTests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:370:  [SVNMirrorTest.test_CheckOutSource] Undefined variable 'CheckOutSource'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:370:  [SVNMirrorTest.test_CheckOutSource] Undefined variable 'source'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:374:  [SVNMirrorTest.test_CheckOutSource] Undefined variable 'c'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:389:  [BuildStepsConstructorTest.generateTests] Undefined variable 'c'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:481:  [BuildStepsTest.generateTests] Undefined variable 'c'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:498:  [BuildStepsTest.test_unnecessary_expected_results] Undefined variable 'c'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:508:  [RunAndUploadPerfTestsTest.assertResults] Undefined variable 'RunAndUploadPerfTests'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:542:  [RunBenchmarkTest.assertResults] Undefined variable 'RunBenchmarkTests'  [pylint/E0602] [5]
Total errors found: 34 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2017-12-05 12:54:01 PST
Comment on attachment 328465 [details]
Proposed patch

rs=me
Comment 4 Aakash Jain 2017-12-05 13:06:24 PST
Fixed style issues in https://bugs.webkit.org/show_bug.cgi?id=180439
Comment 5 Aakash Jain 2017-12-05 14:35:44 PST
Committed r225548: <https://trac.webkit.org/changeset/225548>
Comment 6 Radar WebKit Bug Importer 2017-12-05 14:36:32 PST
<rdar://problem/35865185>