Bug 180426 - [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp
Summary: [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2017-12-05 08:40 PST by Carlos Garcia Campos
Modified: 2017-12-11 00:32 PST (History)
6 users (show)

See Also:


Attachments
Patch (14.41 KB, patch)
2017-12-05 08:46 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-12-05 08:40:27 PST
This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the DTR is created there every time. Only the last directory created is cleaned up by the driver destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by moving it to the start() method like other drivers do (included the base driver implementation). Since API and WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set either in that case.
Comment 1 Carlos Garcia Campos 2017-12-05 08:46:32 PST
Created attachment 328454 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-12-11 00:31:48 PST
Committed r225740: <https://trac.webkit.org/changeset/225740>
Comment 3 Radar WebKit Bug Importer 2017-12-11 00:32:24 PST
<rdar://problem/35962796>