Bug 180424 – [Win] UIScriptController::zoomToScale not implemented

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ali Juma]

+++ This bug was initially created as a clone of Bug #168050 +++

Tests using it fail:

fast/visual-viewport/rtl-zoomed-rects.html
fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html
fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
fast/visual-viewport/viewport-dimensions-under-page-zoom.html
fast/visual-viewport/viewport-dimensions.html
fast/visual-viewport/zoomed-fixed-header-and-footer.html
fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html
fast/visual-viewport/zoomed-fixed.html
fast/visual-viewport/zoomed-rects.html
fast/zooming/client-rect-in-fixed-zoomed.html
fast/zooming/uiscript-zooming.html

[Fujii Hironori]

Created attachment 383026 [details]
Patch

[EWS Watchlist]

Comment on attachment 383026 [details]
Patch

Attachment 383026 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13226855

New failing tests:
fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html

[EWS Watchlist]

Created attachment 383133 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Alex Christensen]

Comment on attachment 383026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383026&action=review

> Tools/DumpRenderTree/win/UIScriptControllerWin.cpp:69
> +    // FIXME: No API to get the page scale factor

I think at this point we probably don't want to fix this.

> Tools/WebKitTestRunner/win/UIScriptControllerWin.cpp:44
> +    callOnMainThread([this, protectedThis = makeRef(*this), callbackID ] {

I don't see why this is necessary.  Can't we just complete the task immediately?  We're never on a non-main thread, right?

[Fujii Hironori]

Comment on attachment 383026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383026&action=review

>> Tools/DumpRenderTree/win/UIScriptControllerWin.cpp:69
>> +    // FIXME: No API to get the page scale factor
> 
> I think at this point we probably don't want to fix this.

Will remove "FIXME:".

>> Tools/WebKitTestRunner/win/UIScriptControllerWin.cpp:44
>> +    callOnMainThread([this, protectedThis = makeRef(*this), callbackID ] {
> 
> I don't see why this is necessary.  Can't we just complete the task immediately?  We're never on a non-main thread, right?

Yes, it's on the main thread, however, it should be run on the next run loop iteration.

[Fujii Hironori]

Created attachment 383326 [details]
Patch for landing

[Fujii Hironori]

Committed r252357: <https://trac.webkit.org/changeset/252357>

[Radar WebKit Bug Importer]

<rdar://problem/57108174>