mastercfg_unittest.py has a BuildBotConfigLoader class which is used to import master.cfg. We should use python imports directly. All the code in this class is no longer required. e.g.: _add_webkitpy_to_sys_path method is unnecessary as Buildbot doesn't depend on webkitpy at all. We should remove this class.
Created attachment 328419 [details] Proposed patch
Comment on attachment 328419 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=328419&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:-32 > - def _add_dependant_modules_to_sys_modules(self): > - from webkitpy.thirdparty.autoinstalled import buildbot > - sys.modules['buildbot'] = buildbot This code was to be able to run mastercfg_unittest.py without installing buildbot and its dependencies. webkitpy autoinstaller installs exactly the same buildbot and twisted version as the build.webkit.org uses.
Good point. I think I need to look into webkitpy more and understand why does webkitpy has buildbot code. Maybe we can move that autoinstaller code here.
Comment on attachment 328419 [details] Proposed patch I'm setting r- because this patch not longer applies on trunk. Also it looks a similar thing has been done on bug 180390. Should we just close this?