Bug 180380 - Web Inspector: Details section headers overlap Classes container in the Computed Styles panel
Summary: Web Inspector: Details section headers overlap Classes container in the Compu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-04 14:49 PST by Matt Baker
Modified: 2017-12-06 15:48 PST (History)
5 users (show)

See Also:

Attachments
[Image] Overlapping header (224.82 KB, image/png)
2017-12-04 14:49 PST, Matt Baker 		no flags Details
Patch (1.65 KB, patch)
2017-12-04 14:50 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch for landing (1.59 KB, patch)
2017-12-06 12:00 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-12-04 14:49:03 PST 
Created attachment 328392 [details]
[Image] Overlapping header

Summary:
Details section headers overlap Classes container in the Computed Styles panel.

Steps to Reproduce:
1. Open Elements > Computed Styles
2. Toggle "Show All", forcing the panel contents to scroll vertically
3. Click the "Classes" button at the bottom to expand the sub-panel
4. Scroll past the Properties section to Box Model
  => Box Model header overlaps the Classes sub-panel
Comment 1 Matt Baker 2017-12-04 14:50:09 PST 
Created attachment 328393 [details]
Patch
Comment 2 WebKit Commit Bot 2017-12-05 22:35:42 PST 
Comment on attachment 328393 [details]
Patch

Rejecting attachment 328393 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 328393, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
76da3136a06d3d9a391..6d3df5707fbafb036dbf92ba09c83742027efd33 100644
|--- Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css	(revision 0)
|+++ Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5511123
Comment 3 Matt Baker 2017-12-06 12:00:36 PST 
Created attachment 328603 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-12-06 14:21:13 PST 
Comment on attachment 328603 [details]
Patch for landing

Clearing flags on attachment: 328603

Committed r225595: <https://trac.webkit.org/changeset/225595>
Comment 5 WebKit Commit Bot 2017-12-06 14:21:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-06 15:48:26 PST 
<rdar://problem/35894911>