Bug 180376 - [Web App Manifest] Support display-mode media feature
Summary: [Web App Manifest] Support display-mode media feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-04 13:40 PST by David Quesada
Modified: 2017-12-07 12:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (40.91 KB, patch)
2017-12-04 15:39 PST, David Quesada 		no flags Details | Formatted Diff | Diff
Patch v2 (45.06 KB, patch)
2017-12-05 17:17 PST, David Quesada 		ggaren: review+
Details | Formatted Diff | Diff
Patch for landing (42.50 KB, patch)
2017-12-06 20:34 PST, David Quesada 		no flags Details | Formatted Diff | Diff
Patch for landing (v2) (42.62 KB, patch)
2017-12-07 08:35 PST, David Quesada 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2017-12-04 13:41:07 PST 
<rdar://problem/35837993>
Comment 2 David Quesada 2017-12-04 15:39:42 PST 
Created attachment 328398 [details]
Patch

Patch for review
Comment 3 David Quesada 2017-12-05 17:17:57 PST 
Created attachment 328534 [details]
Patch v2

Rebased, updated the way ApplicationManifestParser parses the JSON.
Comment 4 Geoffrey Garen 2017-12-05 18:28:33 PST 
Comment on attachment 328534 [details]
Patch v2

r=me
Comment 5 David Quesada 2017-12-06 20:34:17 PST 
Created attachment 328676 [details]
Patch for landing
Comment 6 David Quesada 2017-12-07 08:35:03 PST 
Created attachment 328696 [details]
Patch for landing (v2)

Attempt to fix the EWS errors.
Comment 7 WebKit Commit Bot 2017-12-07 12:04:41 PST 
Comment on attachment 328696 [details]
Patch for landing (v2)

Clearing flags on attachment: 328696

Committed r225639: <https://trac.webkit.org/changeset/225639>
Comment 8 WebKit Commit Bot 2017-12-07 12:04:42 PST 
All reviewed patches have been landed.  Closing bug.