Bug 180368 – [Web App Manifest] Add SPI for applying a manifest to a top-level browsing context

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Quesada]

To run a web app as intended by the manifest, we need the ability to apply a manifest to the browsing context.

[Radar WebKit Bug Importer]

<rdar://problem/35835664>

[David Quesada]

Actually, I already had a radar for this one :/ rdar://problem/34748067

[David Quesada]

Created attachment 328383 [details]
Patch

Patch for review. This depends on 180294.

[Geoffrey Garen]

Comment on attachment 328383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328383&action=review

r=me

> Source/WebCore/page/PageConfiguration.h:81
> +    std::optional<ApplicationManifest> applicationManifest { std::nullopt };

No need to specify nullopt here. The default constructor will do that for you.

[David Quesada]

Created attachment 328532 [details]
Patch for landing

[David Quesada]

Created attachment 328636 [details]
Patch for landing (v2)

Attempt to fix the EWS errors.

[Joseph Pecoraro]

Comment on attachment 328636 [details]
Patch for landing (v2)

View in context: https://bugs.webkit.org/attachment.cgi?id=328636&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:70
> +@property (nonatomic, setter=_setApplicationManifest:) _WKApplicationManifest *_applicationManifest;

This should have a API_AVAILABLE macro with TBA values. Certainly mac, maybe iOS?

    @property ... _WKApplicationManifest *_applicationManifest WK_API_AVAILABLE(macosx(WK_MAC_TBA));

[David Quesada]

Created attachment 328655 [details]
Patch for landing (v3)

Now with API availability annotation

[David Quesada]

Created attachment 328657 [details]
Patch for landing (v4)

Addressed one more piece of feedback from JoePeck: removed #if guards around a class forward declaration.

[WebKit Commit Bot]

Comment on attachment 328657 [details]
Patch for landing (v4)

Clearing flags on attachment: 328657

Committed r225615: <https://trac.webkit.org/changeset/225615>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.