Bug 180362 – Get a directory path to SWServers for storing ServiceWorker registrations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Get a directory path to SWServers for storing ServiceWorker registrations

[Brady Eidson]

Created attachment 328356 [details]
Patch

[Chris Dumez]

Comment on attachment 328356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328356&action=review

r=me

> Source/WebKit/ChangeLog:10
> +

Extra blank line.

[Brady Eidson]

Created attachment 328370 [details]
PFL

[Brady Eidson]

Created attachment 328372 [details]
Patch

[Brady Eidson]

Comment on attachment 328372 [details]
Patch

Waiting for Linux builds on EWS

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Comment on attachment 328372 [details]
Patch

Clearing flags on attachment: 328372

Committed r225490: <https://trac.webkit.org/changeset/225490>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35838345>

[youenn fablet]

Comment on attachment 328372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328372&action=review

> Source/WebKit/StorageProcess/StorageProcess.cpp:390
> +    ASSERT(!path.isEmpty());

This assertion is hit in case of private browsing mode, at least the private browsing mode used by rwt which changes Document sessionID to emptySessionID.
See https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r225492%20(1416)/results.html

[Brady Eidson]

(In reply to youenn fablet from comment #10)
> Comment on attachment 328372 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328372&action=review
> 
> > Source/WebKit/StorageProcess/StorageProcess.cpp:390
> > +    ASSERT(!path.isEmpty());
> 
> This assertion is hit in case of private browsing mode, at least the private
> browsing mode used by rwt which changes Document sessionID to emptySessionID.
> See
> https://build.webkit.org/results/
> Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r225492%20(1416)/
> results.html

Yup, that's totally 100% expected. I wasn't aware any tests ran in private browsing yet.

[Brady Eidson]

Reopening to attach new patch.

[Brady Eidson]

Created attachment 328412 [details]
Patch

[Brady Eidson]

Created attachment 328413 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 328413 [details]
Patch

Clearing flags on attachment: 328413

Committed r225510: <https://trac.webkit.org/changeset/225510>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.