Bug 180361 – AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

* SUMMARY
Implement updated CSS3 Speech for 'speak' and 'speak-as' properties

* NOTES
http://dev.w3.org/csswg/css3-speech/#speaking-props-speak
http://dev.w3.org/csswg/css3-speech/#speaking-props-speak-as

The CSS group rejected our request to go back to the original values for 'speak' even though their draft had stagnated for 6 years. Nevertheless, some good will come out of this. For example, the property values are not mutually exclusive as I originally thought. Note the double vertical bars.

speak-as: normal | spell-out || digits || [ literal-punctuation | no-punctuation ]

e.g. these examples will work.

.telephone {
   speak-as: digits no-punctuation; /* e.g., [phone] */
}

<rdar://problem/10353542>

[chris fleizach]

Created attachment 329714 [details]
patch

[EWS Watchlist]

Attachment 329714 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:3595:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 329717 [details]
patch

[EWS Watchlist]

Comment on attachment 329717 [details]
patch

Attachment 329717 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5736836

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 329722 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329717 [details]
patch

Attachment 329717 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5737005

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 329725 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329717 [details]
patch

Attachment 329717 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5737803

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
svg/css/getComputedStyle-basic.xhtml

[EWS Watchlist]

Created attachment 329727 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[chris fleizach]

Created attachment 329741 [details]
patch

[EWS Watchlist]

Comment on attachment 329741 [details]
patch

Attachment 329741 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5744885

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html

[EWS Watchlist]

Created attachment 329745 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329741 [details]
patch

Attachment 329741 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5744944

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html

[EWS Watchlist]

Created attachment 329746 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329741 [details]
patch

Attachment 329741 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5745087

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html

[EWS Watchlist]

Created attachment 329747 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 329741 [details]
patch

Attachment 329741 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5745064

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html

[EWS Watchlist]

Created attachment 329748 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[chris fleizach]

Created attachment 329929 [details]
patch

[Simon Fraser (smfr)]

I filed this as bug 167692.

[Simon Fraser (smfr)]

*** Bug 167692 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 329929 [details]
patch

Clearing flags on attachment: 329929

Committed r226432: <https://trac.webkit.org/changeset/226432>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Claudio Saavedra]

Hey, as you can see from the EWS bubbles you broke wincairo and wpe. I fixed wpe in https://trac.webkit.org/changeset/226441.

[chris fleizach]

(In reply to Claudio Saavedra from comment #24)
> Hey, as you can see from the EWS bubbles you broke wincairo and wpe. I fixed
> wpe in https://trac.webkit.org/changeset/226441.

Thank you!

[Ryan Haddad]

This change broke the iOS Debug build:
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/2763

duplicate symbol __ZN22AccessibilityUIElement7speakAsEv in:
    /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/libDumpRenderTree.a(AccessibilityUIElement.o)
    /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-iphonesimulator/libDumpRenderTree.a(AccessibilityUIElementIOS.o)

[chris fleizach]

(In reply to Ryan Haddad from comment #26)
> This change broke the iOS Debug build:
> https://build.webkit.org/builders/
> Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/2763
> 
> duplicate symbol __ZN22AccessibilityUIElement7speakAsEv in:
>    
> /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-
> iphonesimulator/libDumpRenderTree.a(AccessibilityUIElement.o)
>    
> /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-
> iphonesimulator/libDumpRenderTree.a(AccessibilityUIElementIOS.o)

looking now

[chris fleizach]

(In reply to chris fleizach from comment #27)
> (In reply to Ryan Haddad from comment #26)
> > This change broke the iOS Debug build:
> > https://build.webkit.org/builders/
> > Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/2763
> > 
> > duplicate symbol __ZN22AccessibilityUIElement7speakAsEv in:
> >    
> > /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-
> > iphonesimulator/libDumpRenderTree.a(AccessibilityUIElement.o)
> >    
> > /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/Debug-
> > iphonesimulator/libDumpRenderTree.a(AccessibilityUIElementIOS.o)
> 
> looking now

Index: Tools/DumpRenderTree/AccessibilityUIElement.cpp
===================================================================
--- Tools/DumpRenderTree/AccessibilityUIElement.cpp	(revision 226449)
+++ Tools/DumpRenderTree/AccessibilityUIElement.cpp	(working copy)
@@ -1538,6 +1538,7 @@
 #endif
 
 #if !PLATFORM(MAC) && !PLATFORM(IOS)
+JSStringRef AccessibilityUIElement::speakAs() { return nullptr; }
 JSStringRef AccessibilityUIElement::pathDescription() const { return 0; }
 void AccessibilityUIElement::setValue(JSStringRef) { }
 #endif
@@ -1556,7 +1557,6 @@
 #endif
 
 #if !PLATFORM(MAC)
-JSStringRef AccessibilityUIElement::speakAs() { return nullptr; }
 void AccessibilityUIElement::setBoolAttributeValue(JSStringRef, bool) { }
 #endif

[Ryan Haddad]

Are you going to land the change, or do you need me to do it?

[chris fleizach]

(In reply to Ryan Haddad from comment #29)
> Are you going to land the change, or do you need me to do it?

I'm working on the change right now. thanks

[Jonathan Bedard]

(In reply to chris fleizach from comment #30)
> (In reply to Ryan Haddad from comment #29)
> > Are you going to land the change, or do you need me to do it?
> 
> I'm working on the change right now. thanks

I've confirmed this change for iOS Simulator Debug builds locally.

[chris fleizach]

(In reply to Jonathan Bedard from comment #31)
> (In reply to chris fleizach from comment #30)
> > (In reply to Ryan Haddad from comment #29)
> > > Are you going to land the change, or do you need me to do it?
> > 
> > I'm working on the change right now. thanks
> 
> I've confirmed this change for iOS Simulator Debug builds locally.

thanks. I was waiting on my local build to finish...

[chris fleizach]

(In reply to chris fleizach from comment #32)
> (In reply to Jonathan Bedard from comment #31)
> > (In reply to chris fleizach from comment #30)
> > > (In reply to Ryan Haddad from comment #29)
> > > > Are you going to land the change, or do you need me to do it?
> > > 
> > > I'm working on the change right now. thanks
> > 
> > I've confirmed this change for iOS Simulator Debug builds locally.
> 
> thanks. I was waiting on my local build to finish...

https://trac.webkit.org/changeset/226450/webkit