Bug 180359 – Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm

[youenn fablet]

Created attachment 328354 [details]
Patch

[Chris Dumez]

Comment on attachment 328354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:165
> +    handleClientUnload();

This looks wrong to me. The fact that removeClientUsingRegistration() is called does not necessarily mean a client was unloaded.

[Chris Dumez]

Comment on attachment 328354 [details]
Patch

I guess it does not matter though because the algorithm is a no-op when the unloaded client is not using the registration.

[Chris Dumez]

Comment on attachment 328354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review

yeah, seems fine given the client unload algorithm.

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:293
> +        return;

Technically the spec does not return here. I don't know if is matters or if it is a bug in the spec. Do we ever want to call tryActivate() on a registration that is uninstalling?

[youenn fablet]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 328354 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328354&action=review
> 
> yeah, seems fine given the client unload algorithm.
> 
> > Source/WebCore/workers/service/server/SWServerRegistration.cpp:293
> > +        return;
> 
> Technically the spec does not return here. I don't know if is matters or if
> it is a bug in the spec. Do we ever want to call tryActivate() on a
> registration that is uninstalling?

Right, spec could be made clearer here.

[WebKit Commit Bot]

Comment on attachment 328354 [details]
Patch

Clearing flags on attachment: 328354

Committed r225483: <https://trac.webkit.org/changeset/225483>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35833226>